fix(scripts): strip ELECTRON_RUN_AS_NODE before spawning Electron#758
Merged
fix(scripts): strip ELECTRON_RUN_AS_NODE before spawning Electron#758
Conversation
VSCode is itself an Electron app and sets ELECTRON_RUN_AS_NODE=1 in
its terminal/extension-host environment. When `yarn watch` or
`yarn scrape` are run from a VSCode integrated terminal, that var
inherits down to the Electron child, forcing it into Node-only mode.
The result: `import { app } from 'electron'` (and `require('electron')`)
fail with "does not provide an export named 'app'", because the GUI
Electron runtime never initializes.
Strip the var from the spawn env in both scripts. No effect on the
postinstall script, which sets it explicitly via cross-env.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.18.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VSCode is itself an Electron app and sets ELECTRON_RUN_AS_NODE=1 in its terminal/extension-host environment. When
yarn watchoryarn scrapeare run from a VSCode integrated terminal, that var inherits down to the Electron child, forcing it into Node-only mode. The result:import { app } from 'electron'(andrequire('electron')) fail with "does not provide an export named 'app'", because the GUI Electron runtime never initializes.Strip the var from the spawn env in both scripts. No effect on the postinstall script, which sets it explicitly via cross-env.